Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: incorrect Go target arch #4363

Merged
merged 4 commits into from
Jul 25, 2024
Merged

hotfix: incorrect Go target arch #4363

merged 4 commits into from
Jul 25, 2024

Conversation

Lennart01
Copy link
Member

Based on https://docs.docker.com/build/guide/multi-platform/#platform-build-arguments
you can use variables like TARGETARCH or TARGETOS to determine the architecture used in the build command
inside the Dockerfile. This would allow multiarch binary builds for the server.

relates #4339
relates #3994

Signed-off-by: Tim Beermann [email protected]

Description

The current multi-arch builds only build the container image for the desired architecture, the go binary inside is still build with the wrong architecture. This PR tries to automatically adopt the build arguments to the related architecture given in the build command.

Changelog

Changed the server Dockerfile to allow platform agnostic build arguments. E.g. arm64 when docker buildx is running for platform linux/arm64.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Lennart01 Lennart01 merged commit d21a986 into main Jul 25, 2024
4 checks passed
@Lennart01 Lennart01 deleted the hotfix/go_target_arch branch July 25, 2024 17:23
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4363.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-84795a9

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-84795a9

Copy link

octomind-dev bot commented Jul 25, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 84795a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants